WebDriver/RemoteProtocol/Meetings/2020/03/25: Difference between revisions
< WebDriver | RemoteProtocol | Meetings
Jump to navigation
Jump to search
(Added meeting on 2020-03-25) |
m (Whimboo moved page Remote/Meetings/2020/03/25 to WebDriver/RemoteProtocol/Meetings/2020/03/25: Reorganization for WebDriver BiDi project documenation) |
||
(5 intermediate revisions by 3 users not shown) | |||
Line 1: | Line 1: | ||
== Agenda == | == Agenda == | ||
* [mmucci] Project Status | |||
* [henrik] Sync strategy for tests with Puppeteer upstream repository | |||
** Lots of changes have been made locally (skipping or re-enabling tests) | |||
** Also changes to the upstream repository were done since our last sync | |||
** I expect we diverge quite a bit now so that a sync will cause a good amount of merge issues | |||
** How often should we do upstream/downstream syncs in the future? | |||
** Fixing issues with tests locally or in upstream repository first (eg. meta key)? | |||
* [harald] Dashboards | |||
* [harald] Explorations | |||
== Roster == | == Roster == | ||
Line 5: | Line 15: | ||
; Present | ; Present | ||
: mmucci, maja, harald, henrik, jgraham, joeleinbinder (Microsoft) | |||
== Minutes == | |||
=== Status update === | |||
mmucci - Status update: on track, slightly ahead of schedule | |||
=== Process of stay in sync with the Puppeteer upstream repository === | |||
* [maja] The next sync might be a pain but not that bad; subsequent syncs won't be a problem | |||
* [james] Lets make changes in m-c and sync every once in a while | |||
* henrik: easier to do in m-c only | |||
* Action - Maja will run a sync soon. | |||
=== Dashboard === | |||
* Harald: https://github.com/puppeteer/puppeteer/issues/5515#issuecomment-600783317 | |||
* Migrate ispuppeteerready dashboard into puppeteer org | |||
* Can Joel help? | |||
* James - we don't have the same type of information as the old dashboard so it's not super important to transfer ownership | |||
* Harald - we want to make sure old one eventually points to the up-to-date dashboard | |||
* Joel - old dashboard was based on the coverage tests | |||
* Joel will ping Andrey | |||
* Harald: report based on data we have now or wait until we have richer data? | |||
* Conclusion: go ahead with our current data, don't block on ownership of previous dashboard | |||
== | === Explorations === | ||
* Harald: Relationship of Remote Protocol to Marionette, RDP; convergence? | |||
* James: expect to have an upgrade path from WebDriver to bidi protocol, so bidi has same featureset as WebDriver plus more. Similarly, Medium/long term goal is that Marionette goes away and its featureset is build on top of new bidi protocol. However, some Marionette features are Firefox-specific (e.g. access to browser chrome). In the short term ktlo for Marionette + Fission changes. RDP unaffected. | |||
** Maja: geckodriver is venue for transition from Marionette to bidi remote protocol; transition invisible to WebDriver users | |||
** James: internal users of Marionette would have to transition to bidi remote protocol | |||
** Harald: super power in Remote Protocl to access browser chrome for example? | |||
** Henrik: some architectural issues anticipated with that. In geckodriver right now we offer the ability to switch to chrome context but as far as I know only Dave Hunt's FoxPuppet client is using chrome context via geckodriver | |||
** Maja: as WebDriver, Remote Protocol will have to allow for browser-specific extensions (such as browser chrome access) | |||
** James: devtools features should not be in scope for Remote Protocol proposal | |||
** Harald: browser vendors want freedom to break their devtools apis | |||
** Joel: my understanding of CDP is the most stable in the devtools APIs (because shared with node) and least stable in the automation APIs | |||
** James: CDP debugging APIs less stable | |||
** Harald: console and debugger space | |||
* Harald: delta between remote protocol and cdp? | |||
** Joel: flexibility in CDP, not being locked into architecture; like WebKit people put everything in automation domain | |||
* Harald: would it make sense to switch RDP to bidi Remote Protocol? Convergence of remote protocols | |||
** Maja: Some parts of CDP can be carried over into remote protocol with only minor changes | |||
** James: Depends on if the APIs can be matched by all browsers | |||
** James: Overlap of automation and devtools needs, like getting network requests | |||
=== Playwright updates from Joel === | |||
* WebKit parts looking good; coming back to Firefox work and clean it up | |||
* Joel will try to set up a dashboard for Playwright against Firefox Nightly | |||
* 1.0 of Playwright | |||
** Wait till end of March, stabilize. Release mid-April | |||
== Progress == | == Progress == | ||
Line 19: | Line 75: | ||
* '''Last meeting:''' 80 Total; 43 Open (53.75%); 37 Resolved (46.25%) [March 4th] | * '''Last meeting:''' 80 Total; 43 Open (53.75%); 37 Resolved (46.25%) [March 4th] | ||
* '''This meeting:''' | * '''This meeting:''' 48 Total; 8 Open (16.67%); 40 Resolved (83.33%) | ||
=== Other indicators === | === Other indicators === | ||
Line 29: | Line 85: | ||
<pre> | <pre> | ||
$ hg log -M -r %commit_from_last_time%::central --template "{node|short}\t{author|person}\t{desc|firstline}\n" remote | $ hg log -M -r %commit_from_last_time%::central --template "{node|short}\t{author|person}\t{desc|firstline}\n" remote | ||
6f8c5bdc7726 Mark Banner Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers | |||
0cb0288d1fe0 James Graham Bug 1607474 - Add logging and expected results to puppeteer-test, r=remote-protocol-reviewers,maja_zf | |||
ff3786893e79 James Graham Bug 1607474 - Add initial expected data for puppeteer tests, r=remote-protocol-reviewers,maja_zf | |||
b411a8d14392 James Graham Bug 1622087 - Handle TERMINATED status in puppeteer tests, r=remote-protocol-reviewers,maja_zf | |||
59d7a91c3bbe Tom Schuster Bug 1621817 - Remove nsIScriptError.strictFlag. r=remote-protocol-reviewers,mccr8,whimboo | |||
a6e52a513529 Maja Frydrychowicz Bug 1622363 - (docs) Fix communication link | |||
50d4048d635e Ed Lee Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-r | |||
279e70eb0f5a James Graham Bug 1622446 - Fix default value for expected status, r=remote-protocol-reviewers,whimboo | |||
d9ace728c606 James Graham Bug 1622446 - Make tbpl treat missing results as unexpected, r=remote-protocol-reviewers,whimboo | |||
eb20e7785d3b James Graham Bug 1623029 - Add --subset to puppeteer-test to support running a subset of tests, r=remote-protocol-revie | |||
e27cfa0f41e5 James Graham Bug 1622906 - Disabling tests is never unexpected, r=remote-protocol-reviewers,whimboo | |||
0e350d2c4b28 Tom Schuster Bug 1621813 - Remove nsIScriptError.exceptionFlag. r=mccr8 | |||
6a8ca36f31e8 Maja Frydrychowicz Bug 1612174 - [remote] Emit "init" lifecycleEvent when readyState is "loading" r=remote-protocol-r | |||
06b9dd699708 Maja Frydrychowicz Bug 1612174 - [remote] Update puppeteer test expectations r=remote-protocol-reviewers,whimboo | |||
ab2525a1da3b James Graham Bug 1624046 - Fix the ordering of puppeteer expected data, r=remote-protocol-reviewers,maja_zf | |||
dbabf2e388fa James Graham Bug 1624046 - Always write results with --write-results, r=remote-protocol-reviewers,maja_zf | |||
9f32172ae499 Henrik Skupin Bug 1623581 - [remote] Refactor Runtime.evaluate and Runtime.callFunctionOn browser chrome tests. r=remote | |||
36920c4ef850 Henrik Skupin Bug 1623581 - [remote] Add "returnByValue" support to Runtime.evaluate. r=remote-protocol-reviewers,maja_z | |||
c92f0faccdb5 Henrik Skupin Bug 1623581 - [remote] Add "awaitPromise" support to Runtime.evaluate. r=remote-protocol-reviewers,maja_zf | |||
9f72cf155767 Henrik Skupin Bug 1623484 - [remote] Runtime.evaluate and Runtime.callFunctionOn return wrong data for Symbol and BigInt | |||
bebf8622dd3b Henrik Skupin Bug 1623581 - [puppeteer] Update expected tests for Puppeteer. r=remote-protocol-reviewers,maja_zf | |||
</pre> | </pre> | ||
Latest revision as of 20:09, 26 February 2021
Agenda
- [mmucci] Project Status
- [henrik] Sync strategy for tests with Puppeteer upstream repository
- Lots of changes have been made locally (skipping or re-enabling tests)
- Also changes to the upstream repository were done since our last sync
- I expect we diverge quite a bit now so that a sync will cause a good amount of merge issues
- How often should we do upstream/downstream syncs in the future?
- Fixing issues with tests locally or in upstream repository first (eg. meta key)?
- [harald] Dashboards
- [harald] Explorations
Roster
- Present
- mmucci, maja, harald, henrik, jgraham, joeleinbinder (Microsoft)
Minutes
Status update
mmucci - Status update: on track, slightly ahead of schedule
Process of stay in sync with the Puppeteer upstream repository
- [maja] The next sync might be a pain but not that bad; subsequent syncs won't be a problem
- [james] Lets make changes in m-c and sync every once in a while
- henrik: easier to do in m-c only
- Action - Maja will run a sync soon.
Dashboard
- Harald: https://github.com/puppeteer/puppeteer/issues/5515#issuecomment-600783317
- Migrate ispuppeteerready dashboard into puppeteer org
- Can Joel help?
- James - we don't have the same type of information as the old dashboard so it's not super important to transfer ownership
- Harald - we want to make sure old one eventually points to the up-to-date dashboard
- Joel - old dashboard was based on the coverage tests
- Joel will ping Andrey
- Harald: report based on data we have now or wait until we have richer data?
- Conclusion: go ahead with our current data, don't block on ownership of previous dashboard
Explorations
- Harald: Relationship of Remote Protocol to Marionette, RDP; convergence?
- James: expect to have an upgrade path from WebDriver to bidi protocol, so bidi has same featureset as WebDriver plus more. Similarly, Medium/long term goal is that Marionette goes away and its featureset is build on top of new bidi protocol. However, some Marionette features are Firefox-specific (e.g. access to browser chrome). In the short term ktlo for Marionette + Fission changes. RDP unaffected.
- Maja: geckodriver is venue for transition from Marionette to bidi remote protocol; transition invisible to WebDriver users
- James: internal users of Marionette would have to transition to bidi remote protocol
- Harald: super power in Remote Protocl to access browser chrome for example?
- Henrik: some architectural issues anticipated with that. In geckodriver right now we offer the ability to switch to chrome context but as far as I know only Dave Hunt's FoxPuppet client is using chrome context via geckodriver
- Maja: as WebDriver, Remote Protocol will have to allow for browser-specific extensions (such as browser chrome access)
- James: devtools features should not be in scope for Remote Protocol proposal
- Harald: browser vendors want freedom to break their devtools apis
- Joel: my understanding of CDP is the most stable in the devtools APIs (because shared with node) and least stable in the automation APIs
- James: CDP debugging APIs less stable
- Harald: console and debugger space
- Harald: delta between remote protocol and cdp?
- Joel: flexibility in CDP, not being locked into architecture; like WebKit people put everything in automation domain
- Harald: would it make sense to switch RDP to bidi Remote Protocol? Convergence of remote protocols
- Maja: Some parts of CDP can be carried over into remote protocol with only minor changes
- James: Depends on if the APIs can be matched by all browsers
- James: Overlap of automation and devtools needs, like getting network requests
Playwright updates from Joel
- WebKit parts looking good; coming back to Firefox work and clean it up
- Joel will try to set up a dashboard for Playwright against Firefox Nightly
- 1.0 of Playwright
- Wait till end of March, stabilize. Release mid-April
Progress
Milestone Status
- Last meeting: 80 Total; 43 Open (53.75%); 37 Resolved (46.25%) [March 4th]
- This meeting: 48 Total; 8 Open (16.67%); 40 Resolved (83.33%)
Other indicators
Changelog
$ hg log -M -r %commit_from_last_time%::central --template "{node|short}\t{author|person}\t{desc|firstline}\n" remote 6f8c5bdc7726 Mark Banner Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers 0cb0288d1fe0 James Graham Bug 1607474 - Add logging and expected results to puppeteer-test, r=remote-protocol-reviewers,maja_zf ff3786893e79 James Graham Bug 1607474 - Add initial expected data for puppeteer tests, r=remote-protocol-reviewers,maja_zf b411a8d14392 James Graham Bug 1622087 - Handle TERMINATED status in puppeteer tests, r=remote-protocol-reviewers,maja_zf 59d7a91c3bbe Tom Schuster Bug 1621817 - Remove nsIScriptError.strictFlag. r=remote-protocol-reviewers,mccr8,whimboo a6e52a513529 Maja Frydrychowicz Bug 1622363 - (docs) Fix communication link 50d4048d635e Ed Lee Bug 1620556 - Automatic code fixes for Prettier 1.19.1 upgrade. r=Standard8,remote-protocol-reviewers,marionette-r 279e70eb0f5a James Graham Bug 1622446 - Fix default value for expected status, r=remote-protocol-reviewers,whimboo d9ace728c606 James Graham Bug 1622446 - Make tbpl treat missing results as unexpected, r=remote-protocol-reviewers,whimboo eb20e7785d3b James Graham Bug 1623029 - Add --subset to puppeteer-test to support running a subset of tests, r=remote-protocol-revie e27cfa0f41e5 James Graham Bug 1622906 - Disabling tests is never unexpected, r=remote-protocol-reviewers,whimboo 0e350d2c4b28 Tom Schuster Bug 1621813 - Remove nsIScriptError.exceptionFlag. r=mccr8 6a8ca36f31e8 Maja Frydrychowicz Bug 1612174 - [remote] Emit "init" lifecycleEvent when readyState is "loading" r=remote-protocol-r 06b9dd699708 Maja Frydrychowicz Bug 1612174 - [remote] Update puppeteer test expectations r=remote-protocol-reviewers,whimboo ab2525a1da3b James Graham Bug 1624046 - Fix the ordering of puppeteer expected data, r=remote-protocol-reviewers,maja_zf dbabf2e388fa James Graham Bug 1624046 - Always write results with --write-results, r=remote-protocol-reviewers,maja_zf 9f32172ae499 Henrik Skupin Bug 1623581 - [remote] Refactor Runtime.evaluate and Runtime.callFunctionOn browser chrome tests. r=remote 36920c4ef850 Henrik Skupin Bug 1623581 - [remote] Add "returnByValue" support to Runtime.evaluate. r=remote-protocol-reviewers,maja_z c92f0faccdb5 Henrik Skupin Bug 1623581 - [remote] Add "awaitPromise" support to Runtime.evaluate. r=remote-protocol-reviewers,maja_zf 9f72cf155767 Henrik Skupin Bug 1623484 - [remote] Runtime.evaluate and Runtime.callFunctionOn return wrong data for Symbol and BigInt bebf8622dd3b Henrik Skupin Bug 1623581 - [puppeteer] Update expected tests for Puppeteer. r=remote-protocol-reviewers,maja_zf
Work
- Milestones
- Development status of Puppeteer beta
- Puppeteer beta dashboard
- Bugzilla queries - Puppeteer Beta
- All project work currently in development
- Available MVP work
- Completed MVP work
- Available Reserve work
- Bug overviews
- Gutenberg dependency tree
- Puppeteer examples dependency tree
- Complete Puppeteer dependency tree
- All ze boogs