WebDriver/RemoteProtocol/Meetings/2019/11/29

From MozillaWiki
Jump to: navigation, search

Agenda

Roster

Present

mmucci, whimboo, ato, maja_zf, AutomatedTester

Regrets

Minutes

puppeteer-alpha progress

mmucci reports that the we're in really good shape, ahead of schedule. There is some slack built-up, which is good in case extra work comes up as we investigate.

Resources

Q&A about contingency, reserve

[Starts at 00'03" in the recording.]

  • Difference between backlog (0), contingency (0), reserve (n); why is contingency 0?
    • Backlog is 0 because all MVP bugs are either completed or in development. We had 2 contingency last week but those have been used up (for a total of 13 in MVP). All the remaining bugs are in reserve. They are not part of the MVP, they are considered as extra work in this milestone. They are available be worked on but they are not our focus for the MVP.
    • The two contingency bugs were picked from the reserve backlog as part of follow-up work.
    • Keep filing work, adding to reserve; keep picking up work as you see fit. You can swap reserve bugs for the remaining MVP bugs if you think some reserve bugs are a higher priority. Otherwise, prioritize MVP and then complete as many reserve bugs as you can.

Security review; shipping in Nightly

[Starts at 00'09" in the recording.]

  • One of the concerns mentioned last week ("known unknowns") was the security review
    • ato decided to declare the security review "done", since we've completed the follow-up work that came out of the security review, and we're not aware of any additional work to be done. We haven't heard back from the team doing the review, so ato has invited them to file follow-up bugs if any additional concerns come up.
    • In turn, the changes to make the remote agent actually ship in the Nightly channel have also been submitted.

Fission update

[Starts at 00'11" in the recording.]

  • whimboo and maja_zf met with ochameau to get advice on using JSWindowActors in the remote agent
    • ochameau strongly recommends that we use JSWindowActors as soon as possible for our content work.
    • whimboo has gotten ochameau's WIP patch working (https://phabricator.services.mozilla.com/D37690) and it makes certain things with frames easier. Without JSWindowActors

you have to write more JS to keep track of frame+browsing context life cycle, and it would have to be rewritten to work with Fission anyway.

    • Best options: either use JSWindowActors now or wait until Q1 to implement support for multiple frames.
    • ato agrees with those options. No point in writing alternative solution now only to rewrite in a couple of months.
  • It's unclear whether frameAttached and frameDetached block gutenberg now, so will prioritize other work first. If we learn they are a blocker, adjust priorities. Otherwise, this will be one of the first things to work on in January.
  • whimboo: Biggest challenge so far is that parent actor and child actor get attached only once, but we support multiple connections but each connection has to communicate with a single parent actor. Need some global handler to figure out which communication goes to which actor.

Redesigning command-line flags

[Starts at 00'24" in the recording.]

Flags are confusing already, and we might want to bake in some flexibility in anticipation of likely future use cases.

See bug comment for details about above concerns: https://bugzilla.mozilla.org/show_bug.cgi?id=1590830

Input from Logmein

[Starts at 00'33" in the recording.]

whimboo is going to get information about Puppeteer usage and priorities from Logmein. The discussion will take place on a mailing list; subscription link has been sent to the team.

Typically, we have one Mozilla-wide mailing list per external company.

Protecting internal methods

[Starts at 00'35" in the recording.]

Nothing prevents a client for using an "internal" method. We need schema validation or a blacklist. For now, filter out underscore methods.

Decisions about MVP priorities

[Starts at 00'51" in the recording.]

Team members should feel free to decide what is high priority as they see fit, as soon as new information comes to light. Update bugs accordingly. No need to wait or ask for permission.

Collaboration Feedback

[Starts at 00'54" in the recording.]

Calling out pros (mostly) and cons of our new style of prioritizing and tracking work.

Discussion for next meeting: Q1 2020

  • Fission work
  • Schema validation: initial planning in Q1. To be tackled later, possibly by an Outreachy participant. Likely in Rust, need to consider questions like dealing branching, backwards compatibility versus breaking changes, expanding the protocol.

Recording

Full recording of the meeting can be viewed here: https://mozilla.zoom.us/recording/share/rmkbkR-JrV0E-BncHLtibxJIO2XVOkr3lYdfFpkDmZ-wIumekTziMw

Actions

Status of Milestone 1

  • Last week: 63 Total; 47 Open (74.6%); 16 Resolved (25.4%); 0 Verified (0%)
  • This week: 75 Total; 50 Open (66.67%); 25 Resolved (33.33%); 0 Verified (0%); (including alpha-reserved)

Changelog

% git log --date=iso --pretty=format:'%ad%x09%H' -- remote/ | awk '$0 >= "2019-11-22" && $0 <= "2019-11-29"' | awk -F $'\t' '{print $2}' | xargs git show -s --format='%h%x09%an%x09%s'
cc42b26092db    Andreas Tolfsen bug 1600081: remote: correct build instructions for startup r=remote-protocol-reviewers,whimboo
9ae5ba973c88    Andreas Tolfsen bug 1590827: remote, browser: request remote agent startup; r=florian,remote-protocol-reviewers,maja_zf
79ad592704c9    Maja Frydrychowicz      Bug 1596888 - (remote) vendor Puppeteer to 8b49dc6
187b6fcb5184    Andreas Tolfsen bug 1599400: remote: vendor puppeteer to c5a72e9
c615b385f889    Mihai Alexandru Michis  Bug 1598971 - Fix spell lint failures. a=lint-fix CLOSED TREE
0f30e2928aed    Sylvestre Ledru Bug 1598971 - codespell: Fix typos in the doc r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,ato
2188331f0ae9    Henrik Skupin   Bug 1598468 - [remote] Temporarily stop emitting the "Target.receivedMessageFromTarget" event. r=remote-protocol-reviewers,ato
9a688fe160c2    Maja Frydrychowicz      Bug 1596888 - (Puppeteer) Add automation preferences Firefox profile; r=remote-protocol-reviewers,ato,whimboo
165914f61371    Andreas Tolfsen bug 1590826: remote: vendor puppeteer 2fff4ea; r=remote-protocol-reviewers,maja_zf
2f03ad3bdd60    Andreas Tolfsen bug 1543115: remote, toolkit: bootstrap from Rust; r=remote-protocol-reviewers,maja_zf
ef7f02d139cc    Andreas Tolfsen bug 1543115: remote: expose nsIRemoteAgent as XPCOM service; r=remote-protocol-reviewers,maja_zf,nika
c2c744e24a88    Andreas Tolfsen bug 1543115: remote: introduce nsIRemoteAgent XPIDL interface; r=remote-protocol-reviewers,maja_zf
0171bb1be828    Andreas Tolfsen bug 1543115: remote: make RemoteAgent.listen() accept strings; r=remote-protocol-reviewers,maja_zf
c64be801124d    Andreas Tolfsen bug 1543115: remote: emit "remote-listening" system notification on startup; r=remote-protocol-reviewers,maja_zf
9d04fd216772    Andreas Tolfsen bug 1543115: remote: set needed prefs earlier at startup; r=remote-protocol-reviewers,maja_zf
b5ef034aab59    Andreas Tolfsen bug 1543115: remote: make RemoteAgent.close() safer; r=remote-protocol-reviewers,maja_zf
ba8b20eac727    Andreas Tolfsen bug 1543115: remote: merge init() and listen(); r=remote-protocol-reviewers,maja_zf
cf2af2849912    Andreas Tolfsen bug 1543115: remote: rename XPCOM manifest for conformity; r=remote-protocol-reviewers,maja_zf

Work

Milestones
Development status of Puppeteer alpha
Puppeteer alpha dashboard
Bugzilla queries
All project work currently in development
Available MVP work
Completed MVP work
Bug overviews
Gutenberg dependency tree
Puppeteer examples dependency tree
Complete Puppeteer dependency tree
All ze boogs

PTO (🍂)

  • ato away Wednesday 27th November and Thursday 5th December
Retrieved from "https://wiki.mozilla.org/index.php?title=WebDriver/RemoteProtocol/Meetings/2019/11/29&oldid=1234141"